Disconnect the WebSocket after an idle period #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deploying the WebSocket reconnection logic, our total connection count slowly grew until nginx stopped being able to handle new connections, leading to a severely degraded experience. Closing the WebSocket for idle consumers should reduce the concurrent connection count. Eventually we will need to handle re-starting the connection anyway (and potentially only starting it on demand).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying the WebSocket reconnection logic, our total connection count slowly grew until nginx stopped being able to handle new connections, leading to a severely degraded experience.
Closing the WebSocket for idle consumers should reduce the concurrent connection count. Eventually we will need to handle re-starting the connection anyway (and potentially only starting it on demand).